Added optional support for urllib2 instead of httplib2#8
Open
jcook793 wants to merge 7 commits intoembedly:masterfrom
Open
Added optional support for urllib2 instead of httplib2#8jcook793 wants to merge 7 commits intoembedly:masterfrom
jcook793 wants to merge 7 commits intoembedly:masterfrom
Conversation
Contributor
|
Hey, This is on my radar, but I think there is a cleaner way by making it easy to subclass the client. I.e: I can image other people wanting to use something other than httplib or urllib2. Thanks! Sean |
Author
|
That's a good idea. I'll work on that and submit another pull request. |
Author
|
This implementation doesn't use inheritance, more of a mixin-type approach. Let me know if you hate it. :) Also let me backout that version # change (using that for the buildout in our GAE project ) so it doesn't get applied to this pull request. |
Author
|
Done |
Author
|
Turns out I didn't understand pull requests (or the definition of "done") as much as I thought I did - now I'm done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project that uses Google App Engine which requires using urllib, urllib2 or httplib for outbound HTTP requests. In this pull request I added support for urllib2 by passing the optional "use_urllib2" parameter when creating an Embedly client object.
Note that I essentially run all the tests twice, once using httplib2 and once using urllib2. It's kind of goofy but I couldn't think of a better way of doing it.